Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated hacks to make evt.modules.spms work with older data production versions #580

Merged
merged 4 commits into from
May 10, 2024

Conversation

gipert
Copy link
Member

@gipert gipert commented May 8, 2024

@ggmarshall this needs testing.

@gipert gipert added the evt build events from hit data label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 48.63%. Comparing base (d53c613) to head (9185cfe).
Report is 2 commits behind head on main.

Files Patch % Lines
src/pygama/evt/modules/larveto.py 0.00% 2 Missing ⚠️
src/pygama/evt/modules/spms.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
- Coverage   50.07%   48.63%   -1.44%     
==========================================
  Files          59       59              
  Lines        7755     7750       -5     
==========================================
- Hits         3883     3769     -114     
- Misses       3872     3981     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert marked this pull request as ready for review May 10, 2024 14:28
@gipert gipert merged commit 629e655 into main May 10, 2024
13 checks passed
@gipert gipert deleted the spms-updates branch May 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evt build events from hit data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant