-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file with LGDO-serialized histograms #18
Conversation
Created with legend-pydataobj w/ legend-exp/legend-pydataobj#98 applied
@apmypb can you test this file in Julia with LegendHDF5IO? |
I added a third test histogram, now also containing units on the axes. |
Thanks, I'll try to get this tested with Julia soon. |
Variable binning works too. Using units however does not work yet, because one can not fit a histogram with units (see JuliaStats/StatsBase.jl#857). |
looks good. here are (both histograms) plotted from python:
Also no python histogram library (that I know of) supports units on axes. So from the python side, this is also a purely informational attribute. |
Exactly like that. The units are just dropped during read in. The actual values of the arrays or ranges are read in correctly and can be displayed accordingly. |
Then I suggest we merge this - @apmypb can you then add reading these histograms to the LegendHDF5IO.jl tests? |
I just renamed I will also add the tests to my legend-pydataobj pull request. |
@oschulz can we get this merged? |
I'll take a final look myself today, then I'll merge it. Sorry for the delay. |
Thanks again @ManuelHu and sorry for the delay! |
Created with legend-pydataobj w/ legend-exp/legend-pydataobj#98 applied
the lh5 file contain two histograms, one with binning defined via a range object, and one with a variable binning (the latter is not mentioned yet in the lh5 spec!)
the data is just a randomly generated 2d gaussian.