Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we write to disk HDF5-settings-related LGDO attributes? #37

Open
gipert opened this issue Nov 9, 2023 · 1 comment
Open

Should we write to disk HDF5-settings-related LGDO attributes? #37

gipert opened this issue Nov 9, 2023 · 1 comment
Labels
compression Waveform Compression help wanted Extra attention is needed

Comments

@gipert
Copy link
Member

gipert commented Nov 9, 2023

We drop the compression and hdf5_settings attributes before writing LGDO to disk, at the moment. This is because their names are specific to this Python implementation (h5py.create_dataset()) at the moment, so we should not write them to disk as they are. They are also redundant, since these settings can be also deduced from the HDF5 metadata (waveform compression is instead documented with attributes specifically defined in our data format specification).

The downside is that if a user wants to load a dataset in memory and dump it again to disk after some minor modifications, they will need to manually specify HDF5/compression settings again, which is quite annoying.

@gipert gipert added help wanted Extra attention is needed compression Waveform Compression labels Nov 9, 2023
@jasondet
Copy link
Contributor

we could detect the setting on lh5.store.read() and set the corresponding attributes at that time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compression Waveform Compression help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants