Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO support for EncodedArrrays #39

Merged
merged 1 commit into from
Apr 8, 2024
Merged

IO support for EncodedArrrays #39

merged 1 commit into from
Apr 8, 2024

Conversation

apmypb
Copy link
Contributor

@apmypb apmypb commented Apr 7, 2024

Add IO support for EncodedArrays, VectorOfEncodedArrays and VectorOfEncodedSimilarArrays

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 89.55224% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.00%. Comparing base (559a601) to head (af8e9a9).

❗ Current head af8e9a9 differs from pull request most recent head e1b25dd. Consider uploading reports for the commit e1b25dd to get more accurate results

Files Patch % Lines
src/types.jl 89.39% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #39      +/-   ##
==========================================
+ Coverage   50.00%   57.00%   +7.00%     
==========================================
  Files           6        6              
  Lines         676      742      +66     
==========================================
+ Hits          338      423      +85     
+ Misses        338      319      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you quickly elaborate on this?

src/types.jl Show resolved Hide resolved
@apmypb apmypb changed the title Dev IO support for EncodedArrrays Apr 8, 2024
@fhagemann fhagemann changed the base branch from dev to main April 8, 2024 15:45
@fhagemann fhagemann merged commit d19f14e into legend-exp:main Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants