Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating extensions #63

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Creating extensions #63

merged 10 commits into from
Nov 19, 2024

Conversation

giriPHM
Copy link
Collaborator

@giriPHM giriPHM commented Oct 17, 2024

No description provided.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 273 lines in your changes missing coverage. Please review.

Project coverage is 48.31%. Comparing base (d1e39ae) to head (3dd37fc).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendGeSimExt.jl 0.00% 176 Missing ⚠️
ext/legend_detector_to_siggen.jl 0.00% 71 Missing ⚠️
ext/mjdsiggen_utils.jl 0.00% 26 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #63       +/-   ##
===========================================
- Coverage   66.01%   48.31%   -17.70%     
===========================================
  Files          22       24        +2     
  Lines         712      979      +267     
===========================================
+ Hits          470      473        +3     
- Misses        242      506      +264     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhagemann
Copy link
Contributor

Is this PR ready to be reviewed?
I still see stuff like @info "27" in there, this gives somewhat WIP vibes..

Copy link
Contributor

@fhagemann fhagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider changing the Project.toml (see my comments about package versions).

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
src/pss.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
@fhagemann fhagemann mentioned this pull request Nov 18, 2024
ext/LegendGeSimExt.jl Outdated Show resolved Hide resolved
@fhagemann fhagemann force-pushed the pseudo-ext-branch branch 5 times, most recently from 851bfa1 to 38c981b Compare November 19, 2024 18:17
@fhagemann fhagemann merged commit 76a1e39 into main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants