Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToDo | stp -> pss #35

Open
2 tasks
sagitta42 opened this issue Jul 21, 2023 · 0 comments
Open
2 tasks

ToDo | stp -> pss #35

sagitta42 opened this issue Jul 21, 2023 · 0 comments

Comments

@sagitta42
Copy link
Contributor

ToDo items from the stp->pss stage

  • siggen sometimes crashes because "event outside of detector" even though SSD removes those. Probably due to grid precision. Currently is in "default settings" -> move to user settings, and also implement a fix (rounding down based on xtal_grid precision)
  • SSD already takes time step as input i.e. in simulation_settings can put "time_step"=>1 and it's propagated to SSDSimulator etc. -> make same for siggen. Also better change to "time_step_in_ns" in settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sagitta42