Allow partitioninfo to filter categories
#86
+60
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 41.95% 42.07% +0.11%
==========================================
Files 26 26
Lines 1971 1975 +4
==========================================
+ Hits 827 831 +4
Misses 1144 1144 ☔ View full report in Codecov by Sentry. |
fhagemann
reviewed
Dec 13, 2024
| @@ -107,7 +107,7 @@ function get_partitionvalidity(data::LegendData, ch::ChannelIdLike, det::Detecto | |||
| # unpack | |||
| ch, det, part = ChannelId(ch), DetectorId(det), DataPartition(part) | |||
| # get partition validity | |||
| partinfo = partitioninfo(data, ch, part) | |||
| partinfo = partitioninfo(data, ch, part; category=cal) | |||
There was a problem hiding this comment.
I believe this should be cat instead of cal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partitioninfoallows to filter foranalysis_runsonly to be able to parse:phyand:cal