Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix lprops #85

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Bug fix lprops #85

merged 1 commit into from
Dec 10, 2024

Conversation

theHenks
Copy link
Collaborator

To properly parse units with e.g. special units from UnitfulAtomic, the function unit_from_string from LegendDataTypes is now used to avoid that.

@theHenks theHenks requested a review from fhagemann December 10, 2024 11:27
@theHenks theHenks self-assigned this Dec 10, 2024
@theHenks theHenks added the bug Something isn't working label Dec 10, 2024
Project.toml Show resolved Hide resolved
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41.95%. Comparing base (250b02a) to head (f67289d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/lprops.jl 46.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   41.96%   41.95%   -0.01%     
==========================================
  Files          26       26              
  Lines        1959     1971      +12     
==========================================
+ Hits          822      827       +5     
- Misses       1137     1144       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz
Copy link
Contributor

oschulz commented Dec 10, 2024

Let's duplicate the units_from_string function in LegendDataManagement, instead of depending on LegendDataTypes.

This is a special situation: We want to spin off most of LegendHDFIO into a standalone registered package, and that function would move there then. So LegendDataManagement, which would not depend on that package, needs it's own version of the function anyway.

@fhagemann fhagemann force-pushed the patch_unitful branch 3 times, most recently from a706aa0 to a55cede Compare December 10, 2024 12:48
@fhagemann
Copy link
Contributor

Let's duplicate the units_from_string function in LegendDataManagement, instead of depending on LegendDataTypes.

This is a special situation: We want to spin off most of LegendHDFIO into a standalone registered package, and that function would move there then. So LegendDataManagement, which would not depend on that package, needs it's own version of the function anyway.

This should be done now.

@fhagemann fhagemann merged commit 0d3faa7 into main Dec 10, 2024
11 checks passed
@fhagemann fhagemann deleted the patch_unitful branch December 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants