Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing updates #22

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Processing updates #22

merged 8 commits into from
Jan 26, 2024

Conversation

theHenks
Copy link
Collaborator

Added functionality which was so far in the dataflow:

  • is_analysis_run checks if the run is a analysis run
  • start_key returns the starting FileKey for a given period and run
  • phy_livetime returns the livetime for a given run and period

Also, I extended the channelinfo to be able to get the info for a given run and period by using the start_key as a reference and also to get a handy access to the :geds subsytem with

channelinfo(l200, (:p03, :r000, :cal))
channelinfo(l200, (:p03, :r000, :cal); system=:geds, processable=true)

This makes this whole process of getting filekeys etc way more handy and the user can just get the channelinfo for a given run much more human readable.

I will also move some of the addprocs functionality and try to start with some of the logging stuff.
Maybe @oschulz, you could also share some ideas here. The missing features are here a way to first create Markdown logs and then write them.
Then, a function savelegendfig would be nice which automatically generates figure names and saves a given figure.
And the option to save units in the PropDicts as discussed.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (a898a51) 50.65% compared to head (59e5b50) 48.96%.

Files Patch % Lines
src/dataprod_config.jl 0.00% 26 Missing ⚠️
src/legend_data.jl 45.45% 12 Missing ⚠️
src/filekey.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   50.65%   48.96%   -1.69%     
==========================================
  Files          15       15              
  Lines         922      966      +44     
==========================================
+ Hits          467      473       +6     
- Misses        455      493      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/dataprod_config.jl Outdated Show resolved Hide resolved
src/dataprod_config.jl Show resolved Hide resolved
src/legend_data.jl Outdated Show resolved Hide resolved
@theHenks
Copy link
Collaborator Author

Ready to merge now from my side. What do you say @oschulz ?

@oschulz oschulz merged commit ce75dd6 into legend-exp:main Jan 26, 2024
6 of 9 checks passed
@oschulz
Copy link
Contributor

oschulz commented Jan 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants