-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing updates #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 50.65% 48.96% -1.69%
==========================================
Files 15 15
Lines 922 966 +44
==========================================
+ Hits 467 473 +6
- Misses 455 493 +38 ☔ View full report in Codecov by Sentry. |
oschulz
reviewed
Jan 25, 2024
oschulz
reviewed
Jan 25, 2024
oschulz
requested changes
Jan 25, 2024
oschulz
reviewed
Jan 25, 2024
Ready to merge now from my side. What do you say @oschulz ? |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality which was so far in the dataflow:
is_analysis_run
checks if the run is a analysis runstart_key
returns the starting FileKey for a given period and runphy_livetime
returns the livetime for a given run and periodAlso, I extended the
channelinfo
to be able to get the info for a given run and period by using thestart_key
as a reference and also to get a handy access to the:geds
subsytem withThis makes this whole process of getting filekeys etc way more handy and the user can just get the
channelinfo
for a given run much more human readable.I will also move some of the
addprocs
functionality and try to start with some of the logging stuff.Maybe @oschulz, you could also share some ideas here. The missing features are here a way to first create Markdown logs and then write them.
Then, a function
savelegendfig
would be nice which automatically generates figure names and saves a given figure.And the option to save units in the
PropDicts
as discussed.