Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not mark tx as finalized until it is mined #12

Open
troggy opened this issue Jun 7, 2019 · 0 comments
Open

do not mark tx as finalized until it is mined #12

troggy opened this issue Jun 7, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@troggy
Copy link
Member

troggy commented Jun 7, 2019

EMM should only mark tx as finalized when corresponding exit tx is really landed into root chain.

Given:

  1. Fast exit is submitted
  2. EMM starts an exit transaction on a root network
  3. exit transaction is failed for whatever reason

Expected:
transaction should not be marked as finalized in EMM database

Actual:
transaction is marked as finalized

Consequences:
when failed tx marked as processed, EMM won't retry exit and money will struck in exit handler.

Manual workaround:
to push stuck txs through, set finalized attribute to 0 for corresponding database record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant