Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to trigger deploy-recipe-action without labels #6

Closed
jbusecke opened this issue Aug 2, 2023 · 4 comments
Closed

Not able to trigger deploy-recipe-action without labels #6

jbusecke opened this issue Aug 2, 2023 · 4 comments

Comments

@jbusecke
Copy link
Collaborator

jbusecke commented Aug 2, 2023

To circumvent #5 I tried to set select_recipe_by_label to false but nothing was run.

I am not sure if this was as intended. Just wanted to note this. I guess for some of the discussed cases here we might not want to use labels at all so having this option might become relevant.

@cisaacstern
Copy link
Contributor

Not certain why nothing was run, but there is a bug in pangeo-forge-runner which will prevent this from working, see comment in action here:

https://github.com/pangeo-forge/deploy-recipe-action/blob/256da2916b5f17f358c5e5b0442458645cadb9f0/action/deploy_recipe.py#L117-L123

@jbusecke
Copy link
Collaborator Author

jbusecke commented Aug 7, 2023

Ah that makes sense and will also be important for what I described here

@jbusecke
Copy link
Collaborator Author

jbusecke commented Aug 7, 2023

The issue is that in this line will evaluate to true with either true or false input.
EDIT: We were able to circumvent this by setting the input to "".

@jbusecke
Copy link
Collaborator Author

jbusecke commented Sep 1, 2023

Closed via #9

@jbusecke jbusecke closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants