03: fix explanation of capture-avoiding substitution #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by Kayla Thomas [1], the paragraph on capture-avoiding substitution used an example that didn't actually demonstrate capture-avoiding substitution. While I was at it, I also made the explanation a bit more explicit. [1] https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/.22Metaprogramming.20in.20Lean.204.22/near/473287822
JLimperg
force-pushed
the
capture-avoiding-subst
branch
from
be9dca3
to
9f128ae
Compare
|
This looks good to me from reading it twice and trying to follow it. I'll wait to see if anyone who's an expert on metaprogramming has a comment (besides you who obviously are) just in case I missed something, but otherwise if not this seems good to go. Appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by Kayla Thomas [1], the paragraph on capture-avoiding substitution used an example that didn't actually demonstrate capture-avoiding substitution.
While I was at it, I also made the explanation a bit more explicit.
[1] https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/.22Metaprogramming.20in.20Lean.204.22/near/473287822