Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

succ_le_succ theorem description incorrect #75

Open
ptrbman opened this issue Aug 28, 2024 · 1 comment
Open

succ_le_succ theorem description incorrect #75

ptrbman opened this issue Aug 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ptrbman
Copy link

ptrbman commented Aug 28, 2024

In the Advanced Multiplication World, Level 4/10, the description of the succ_le_succ theorem is described as

(x y : ℕ) (hx : MyNat.succ x ≤ MyNat.succ y) : x ≤ y

succ_le_succ x y is a proof that if succ x ≤ succ y then x ≤ y.

However, when applying the theorem, it instead mimics the rule found at (https://lovettsoftware.com/NaturalNumbers/InequalityWorld/Level8.lean.html):

For all naturals a and b, if a ≤ b, then succ a ≤ succ b.

In short, when applying it to
succ 0 ≤ succ a_1
I get
succ (succ 0) ≤ succ (succ a_1)
instead of
0 ≤ a_1

I do not know which is the intended solution but at least I am confused from reading the help.

@joneugster
Copy link
Collaborator

You are right that the analogue theorem in Lean Core is called Nat.le_of_succ_le_succ, so it would be better if the NNG renamed this lemma (which you proved in Level Inequality 9) from succ_le_succ to le_of_succ_le_succ to match the actual name in Lean!

If you want to make a PR, please do! Otherwise I'll just leave this open until I do the next cleanup round.

@joneugster joneugster added the bug Something isn't working label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants