-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PerConnectionApolloHandler sends wrong sub-protocol #147
Comments
Meanwhile I realised the implemented protocol simply older than the currently recommended that Postman uses. |
Yes, true. I figured there's no point in implementing the new protocol in SPQR since Spring itself already does. I'll release SPQR Starter 2.0.0.rc1 soon, possibly even today. The new version removes SPQR's entire communication layer and uses Spring directly. This will obviously be a breaking change, but it shouldn't cause too much trouble. |
Hi @kaqqao, is there any update on this, by any chance? It would be great if there is an example to use Spring for communication with the current SPQR starter. |
I tried subscribe with Postman but it fails with
Server sent no subprotocol
:I found that the client sends
graphql-transport-ws
sub-protocol but server only tests tographql-ws
becausegetSubProtocols()
return only that. The official protocol is thegraphql-transport-ws
as you see here: https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.mdThe text was updated successfully, but these errors were encountered: