-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.js #4
base: master
Are you sure you want to change the base?
Conversation
Quick update to fix the package crashing as mentioned in leadstoloyals#3
I'm not sure why you get the error, because It's probably related to a combination of the way the Bignumber repo was setup and your js-bundler. More people reported the problem.
I'm not sure if your fix is introducing a problem with other bundlers... |
@christiaanwesterbeek I noticed you dont have a LICENSE.MD in your repo, can i fork this project and just work off that? i have to use async/await in my workspace. |
Create LICENSE
I'm fine with that. We can also consider to bring you modernisations back to this repo afterwards and create a 2.x version if it's incompatible with the current 1.x. |
@christiaanwesterbeek yeah, this project uses the depreciated request NPM package. i can modernize by switching to axios for http requests. |
@christiaanwesterbeek i completed my PR and added a createGiftCardAsync() method to allow promise-based API access through axios. it should not require a major version change since i just added an API endpoint without breaking the existing API. let me know iif you need anything else. |
It looks backward compatible, and if you had the same experience. I think I can merge this one in and release a 1.1 on npm which is a minor version increment. |
@christiaanwesterbeek sounds good, when can we publish the minor version to NPM? |
Quick update to fix the package crashing as mentioned in #3