Desktop: Accessibility: Prevent overwrite mode toggle shortcut from conflicting with screen reader shortcuts #11447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Linux, the Orca screen reader's default modifier key is insert. Before this pull request, pressing insert as part of a screen reader shortcut (e.g. insert-h), entered overwrite mode.
This pull request:
keyUpHandler
CodeMirror extension was created to allow this.Testing plan
This pull request adds a new
overwriteModeExtension
automated test that verifies that the following process does not enable insert mode:Additionally, on Fedora 41:
onkeyup
event handler is not invoked when the user releases insert (though theonkeydown
handler is on key down). With Orca disabled, bothonkeydown
andonkeyup
are received.