Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop, Mobile: Fixes #11318: Upgrade CodeMirror packages #11440

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 25, 2024

Summary

This pull request resolves #11318 by upgrading to the latest @codemirror/ packages.

Note

For future reference, it was necessary to run

bash$ yarn dedupe '@codemirror/*' && yarn dedupe '@lezer/*'`

after upgrading package versions and running yarn install. This removed duplicate copies @codemirror/ and @lezer/ packages created by the upgrade. Duplicate copies of these libraries can cause CodeMirror to not work properly by causing instanceof and === checks fail.

Testing plan

  1. Start Joplin (desktop, Fedora 41).
  2. Create note list with content
    - <div>test</div>
  3. Move the cursor to the end of the </div>.
  4. Press enter.
  5. Verify that a new list item has been added.

@laurent22 laurent22 merged commit 0275434 into laurent22:dev Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List autocompletion not working if current list item ends with HTML code
2 participants