Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Splash on Startup #6330

Open
elmodor opened this issue Mar 27, 2022 · 17 comments
Open

White Splash on Startup #6330

elmodor opened this issue Mar 27, 2022 · 17 comments
Labels
backlog We'll get to it... eventually... bug It's a bug enhancement Feature requests and code enhancements

Comments

@elmodor
Copy link

elmodor commented Mar 27, 2022

Environment

Joplin version: Joplin 2.7.15 (prod, win32) / 2.7.15 (prod, linux) (Appimage)
Platform: Windows / Linux
OS specifics: Win10 (10.0.19043 Build 19043) / Arch

Steps to reproduce

  1. Setting -> Appearance -> Set "Theme" to "Dark"
  2. "Automatically switch theme to match system theme" is not checked
  3. Close Joplin
  4. Open Joplin - notice white screen
  5. Wait until it is loaded - notice dark background

Describe what you expected to happen

I would expect that the first screen which Joplin shows has no white background but a dark background as well.

Screenshots

First screen when Joplin starts:
joplin_white

After 1-2 seconds when Joplin is loaded:
joplin_loaded

Other Infos

Sync enabled
Active Plugins: Simple Backup
No other Adjustments made in the "Appearance" Settings

@elmodor elmodor added the bug It's a bug label Mar 27, 2022
@CalebJohn
Copy link
Collaborator

Thanks for re-creating this. For context, this report is a followup to #5311 which reported two similar issues. One of which was fixed and the issue was closed.

This issue however has not been resolved yet.

I see 3 viable solutions:

  1. (Mentioned in White splashes during webview initialization #5311) Wait until the application is fully loaded before displaying anything.
  • This is the easiest solution because it only involves moving code around
  • I don't like this solution because it means the user will need to wait potentially a long time without any indication that Joplin is loading
  1. Apply a "splash screen" during startup
  1. (Linked in White splashes during webview initialization #5311) Load the settings.json file, extract the theme and apply an appropriate background colour
  • This is probably the simplest fix from the user perspective
  • It involves a kludge (Joplin would be loading settings.json in two different locations)

Personally I think 2 is the best solution. It will give Joplin a more polished feel without adding much complexity. Of course, the best solution is 1 combined with major updates to make Joplin load faster.

@KaviiSuri
Copy link

Is this issue up for grabs? I would love to pick it up

@elmodor
Copy link
Author

elmodor commented Mar 29, 2022

2. Apply a "splash screen" during startup


* It looks like this can be handled pretty simply by having a popup window that [displays a simple html file](https://medium.com/red-buffer/how-to-create-a-splash-screen-for-electron-app-602b4da406d)

* Would also include the solution from [installation error #1](https://github.com/laurent22/joplin/issues/1)

That does sound like a good solution indeed. I assume the splash screen would be the joplin logo? If the splash screen has any background, then it should also respect the theme color - so either dark or light.

I would be fine with either your proposed solution 2. or 3.

@KaviiSuri I'm not going going to work on this so (from my side) feel free to give it a go.

@KaviiSuri
Copy link

I'll definately give it a try!

@CalebJohn
Copy link
Collaborator

@KaviiSuri Please hold up, we need to decide what the solution is first.

@elmodor For solution 2 above, I was thinking that the splash would be Joplin blue, that gets us around the issue of needing theme color.

@KaviiSuri
Copy link

@CalebJohn I'm waiting for the go ahead, i was actually hoping to get it included in my GSOC intro on the forum.

I love the project and would love to contribute to the project fulltime for the next 2 months.

Will definitely need your guidance for it though😁😁

@Daeraxa
Copy link
Collaborator

Daeraxa commented Apr 2, 2022

@KaviiSuri it would be better to look for a triaged issue to solve in the short term rather than wait on this

@KaviiSuri
Copy link

@KaviiSuri it would be better to look for a triaged issue to solve in the short term rather than wait on this

Thanks, I'll look for one, if you have any on your mind, please do let me know!

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label May 2, 2022
@elmodor
Copy link
Author

elmodor commented May 2, 2022

The issue is still present

@KaviiSuri
Copy link

I was waiting for the decision on the details as referenced above by @CalebJohn

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label May 3, 2022
@pshirshov
Copy link

I have to say that this is continuing to happen not only on loading but also when I switch between editor/preview.

@github-actions
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Jun 19, 2022
@CalebJohn CalebJohn added enhancement Feature requests and code enhancements backlog We'll get to it... eventually... and removed stale An issue that hasn't been active for a while... labels Jun 19, 2022
@elmodor
Copy link
Author

elmodor commented Jun 21, 2022

The issue is still present

@securegh
Copy link

I am running Joplin version 3.0.15 on Fedora 40 and this issue is still present, one more detail, I am using the setting to startup the application minimized in the tray icon and its still get the white splash on startup then the application goes to tray.
I wanna have Joplin on autostart, but I don't want to get the white splash whenever I startup my desktop.
Please, a fix is much appreciated, thank you!

@securegh
Copy link

This might be a solution to this issue: https://www.christianengvall.se/electron-white-screen-app-startup/

@securegh
Copy link

Any progress on this issue, I just updated to the latest release 3.1.24 and this issue is still present.
A fix would be much appreciated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... bug It's a bug enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

6 participants