-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Fixes #11408: Correct file path of OneNote converter on release build #11410
Conversation
Normally we put such files in the |
|
I was looking why I chose to use To avoid adding Rust to the docker server image I end up removing the lines that imports I'm trying to think if there is anything else I can do to avoid this. Error that happens if I try to build without
(It can't find package because it was deleted with
|
|
I updated the PR as requested, testing again on dev and release version on Linux. I also removed some information from the package.json that wasn't being used (requireDynamic can't return the typescript type, so I removed it from this entry also) |
That looks good now, thanks Pedro |
Fixes #11408
Summary
When we added
onenote-converter
to3.2.3
I end-up forgetting to test the release build.Testing it I found out that the
requireDynamic
call that we have onInteropService_Importe_OneNote
was pointing it out to a file that doesn't exist on the release build.The file doesn't exist there because the path that was being used is from the file to
packages/onenote-converter
, instead of pointing it out to the module inside liblib/node_modules/@joplin/onenote-convert
.Testing
Testing on dev
git clean -dfx
in the root directory of Joplinyarn
cd packages/onenote-converter && IS_CONTINUOUS_INTEGRATION=1 yarn build
cd ../app-desktop && yarn start
Testing on release
git clean -dfx
in the root directory of Joplinyarn
cd packages/onenote-converter && IS_CONTINUOUS_INTEGRATION=1 yarn build
cd ../app-desktop && yarn dist
dist/Joplin-3.2.3.AppImage