ci: use common definition of C++ versions #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-237167/shared-cpp-versions
branch
5 times, most recently
from
48e5cc9 to
9f245a4
Compare
cwaldren-ld
commented
May 14, 2024
| @@ -4,6 +4,8 @@ FROM debian:bookworm | |||
| ARG VERSION=2.1.0 | |||
| # {{ x-release-please-end }} | |||
|
|
|||
| ARG CPP_SDK_VERSION=3.3.3 | |||
|
|
|||
There was a problem hiding this comment.
In these dockerfiles, the CPP_SDK_VERSION arg is injected by CI. But since it's also hardcoded in the file (so that people can run these examples locally), we'd still have to remember to update these manually.
See PR body for a solution.
cwaldren-ld
force-pushed
the
cw/sc-237167/shared-cpp-versions
branch
from
9f245a4 to
b0a1281
Compare
keelerm84
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates some of the places we need to specify C++ version numbers into a single
cpp-sdk-versions.envfile.This is a similar approach to Relay Proxy.
Updating this file will update:
But it won't update the versions found in README or in the Docker files themselves (as they have default values for the new build arg I've introduced.)
We need to consider the testing strategy going forward. Should we test a min version, and then also a "current" version? And if so, is that current going to float somehow (like using github's releases API to grab the latest), or be pinned to the latest explicitly (via a workflow, or Renovate or something.)