feat: Add support for client-side prerequisite events. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
changed the title
kinyoklion
commented
Oct 14, 2024
There was a problem hiding this comment.
Just linting changes in this file.
kinyoklion
commented
Oct 14, 2024
| value, | ||
| variationIndex: variationIndex ?? null, | ||
| reason: reason ?? null, | ||
| }; | ||
| if (prerequisites) { |
There was a problem hiding this comment.
This isn't in the object construction because I don't want every eval to have a specified, but undefined, prerequisite field.
prerequisites: undefined.
kinyoklion
commented
Oct 14, 2024
| }, | ||
| eventFactory, | ||
| ); | ||
| this.evaluateCb(flag, context, resolve, eventFactory); |
There was a problem hiding this comment.
Unrelated to primary changes, just removing leftover code duplication.
kinyoklion
commented
Oct 15, 2024
| @@ -18,9 +18,10 @@ export function createSuccessEvaluationDetail( | |||
| variationIndex?: number, | |||
| reason?: LDEvaluationReason, | |||
| ): LDEvaluationDetail { | |||
| return { | |||
| const res: LDEvaluationDetail = { | |||
There was a problem hiding this comment.
This was an intermediate change as I was sorting detail. It could be removed, but it doesn't hurt anything.
tanderson-ld
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the server-side implementation for allFlagsState evaluation for bootstrap, server-side LDEvaluationDetail, client-side LDEvaluationDetail, and client-side events for prerequisites.
This version only includes direct pre-requisites, and the client-side evaluation uses variation methods versus directly sending events.
BEGIN_COMMIT_OVERRIDE
feat: Add support for client-side prerequisite events.
feat: Add support for prerequisite details to evaluation detail.
feat: Add prerequisite information to server-side allFlagsState.
END_COMMIT_OVERRIDE
SDK-686
SDK-682