chore: rn sdk use localstorage for bootstrapping #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore tests for synchronization.
…n check for patch and delete. added test for inExperiment.
…nges. add patch and delete unit tests. mock streamer now supports patch and delete commands.
… infinite loop when flag is deleted.
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
|
This pull request has been linked to Shortcut Story #225809: Use localstorage for bootstrapping rn sdk. |
yusinto
commented
Dec 18, 2023
| @@ -44,6 +44,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@launchdarkly/js-client-sdk-common": "0.0.1", | |||
| "@react-native-async-storage/async-storage": "^1.21.0", | |||
There was a problem hiding this comment.
We need this now since AsyncStorage is removed in 0.73.
yusinto
commented
Dec 19, 2023
|
|
||
| export default class ReactNativeLDClient extends LDClientImpl { | ||
| constructor(sdkKey: string, options: LDOptions = {}) { | ||
| const logger = | ||
| options.logger ?? | ||
| new BasicLogger({ | ||
| level: 'info', | ||
| level: 'debug', |
There was a problem hiding this comment.
I intentionally left this as debug for the alpha.
… unused apis and options.
kinyoklion
reviewed
Dec 19, 2023
| @@ -1,4 +1,4 @@ | |||
| export type EventName = 'connecting' | 'ready' | 'error' | 'change'; | |||
There was a problem hiding this comment.
Are you keeping a list of breaking changes for when we do a js-client release? Things like this seem like they could be easy to slip through the cracks.
There was a problem hiding this comment.
I plan to submit a follow up PR to update all comments, readme and docs including breaking changes. I want to get the code reviewed asap first. The connecting event is updated to initializing though to follow @cwaldren-ld 's spec.
This implements feedback from #326. * Run synchronization logic for all `change` events. * Removed `ready` event and use `change` instead. * Callback argument for `change` is now just a string array of flag keys. * Removed config options `stream` and `useReport` for now for this alpha.
…ndependent yarn project.
kinyoklion
reviewed
Dec 20, 2023
kinyoklion
reviewed
Dec 20, 2023
kinyoklion
requested changes
Dec 20, 2023
kinyoklion
reviewed
Dec 21, 2023
yusinto
commented
Dec 22, 2023
Implement tombstoning based on feedback frrom #326.
kinyoklion
approved these changes
Dec 22, 2023
yusinto
deleted the
yus/sc-225809/use-localstorage-for-bootstrapping-rn-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please run the example app as well if you can by running
yarn iosfrom thereact-nativefolder. Note that expo 49 only supports rn 0.72. Expo 50 will work with 0.73 and it's in beta with full release coming in about month. Thank you for reviewing.