chore: implement identify #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of createSafeLogger.
* Improved emitter design * Improved jest config * Added unit tests
Added Configuration class and options validation for js client common.
Co-authored-by: Yusinto Ngadiman <[email protected]>
Co-authored-by: Yusinto Ngadiman <[email protected]> resolves #285
Large pr but mostly trivial changes to import paths because mocks have been moved to its own private project `@launchdarkly/private-js-mocks`: * Refactored mocks to its own project `@launchdarkly/private-js-mocks`. * Better eslint rule for `no-unused-vars` to avoid disabling this rule sporadically.
CI failed because `yarn workspaces foreach -pR --topological-dev --from '@launchdarkly/xxx' run build`. This is because `topological-dev` instructs yarn to build all deps (prod & dev) prior to running build in the current workspace. Since `mocks` need types from `common` this fails. This pr adds a `build-types` command to common which gets run prior to mocks `build` command to ensure common types exist for mocks to be built successfully.
First attempt to implement an initial flag fetch followed by emitting events. I also added comments like this: ```tsx Dom api usage: xxx ``` There are three right now: fetch, btoa and EventTarget. I left comments in the code for react native how to deal with these. --------- Co-authored-by: LaunchDarklyReleaseBot <[email protected]> Co-authored-by: Ryan Lamb <[email protected]>
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
|
This pull request has been linked to Shortcut Story #220941: Implement identify. |
louis-launchdarkly
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of identify, good enough for an alpha release.