chore: Disable diagnostic events when running contract tests. #292
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #219494: Disable diagnostic events for contract tests for node.. |
kinyoklion
requested review from
yusinto and
louis-launchdarkly
as code owners
yusinto
reviewed
Oct 3, 2023
| @@ -9,6 +9,7 @@ export { badCommandError }; | |||
| export function makeSdkConfig(options, tag) { | |||
| const cf = { | |||
| logger: sdkLogger(tag), | |||
| diagnosticOptOut: true | |||
| }; | |||
| const maybeTime = (seconds) => | |||
| seconds === undefined || seconds === null ? undefined : seconds / 1000; | |||
There was a problem hiding this comment.
Unrelated, but this can be simplified:
Suggested change
| seconds === undefined || seconds === null ? undefined : seconds / 1000; | |
| !seconds ? undefined : seconds / 1000; |
There was a problem hiding this comment.
> let seconds = 0;
undefined
> !seconds ? undefined : seconds/1000
undefined
> seconds === undefined || seconds === null ? undefined : seconds/1000
0
I do not know if our test execution does any tests where it sets to 0, but if it does, then the results would be substantially different. As undefined will get default times, and 0 may or may not depending on the check.
There was a problem hiding this comment.
Now that we are post 8.0 I should convert this to typescript and I could make things like this at least look a little cleaner. This is still the original implementation from Eli, because I wanted to validate compatibility originally.
yusinto
approved these changes
Oct 3, 2023
kinyoklion
deleted the
rlamb/sc-219494/disable-diagnostic-contract-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some investigation and found that the intermittent issues with contract tests seem to be related to how the test harness handles them. We do not actually test them using the test harness, so I am disabling them now to improve CI and release robustness.
I've basically been running the contract tests in a loop. Usually they fail in a few hours, but with diagnostic opt out they ran overnight.
I was testing them in combination with some other robustness improvements, but I am re-testing now with just this change. Those changes can be independent.
Once we know what is going on the test harness side we should be able to re-enable these, but it likely isn't worth doing unless there are some tests for them.