Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add <algorithm> header to logging_c_binding_test.cpp #417

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Jun 17, 2024

Test uses std::remove_if which is found in the<algorithm> header. It happens that our compilers/configuration doesn't need it, but others do.

@cwaldren-ld cwaldren-ld changed the title tests: add <algorithm> header to logging_c_binding_test.cpp test: add <algorithm> header to logging_c_binding_test.cpp Jun 17, 2024
@cwaldren-ld cwaldren-ld marked this pull request as ready for review June 17, 2024 21:21
@cwaldren-ld cwaldren-ld requested a review from a team June 17, 2024 21:21
@cwaldren-ld cwaldren-ld added the package: shared/internal Issues affecting the internal library. label Jun 17, 2024
@cwaldren-ld cwaldren-ld merged commit effc049 into main Jun 18, 2024
23 of 24 checks passed
@cwaldren-ld cwaldren-ld deleted the cw/sc-247660/algorithm-header branch June 18, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: shared/internal Issues affecting the internal library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants