fix: initialization of LDFlagListener #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #214881: Extract common bindings from client to common. |
cwaldren-ld
commented
Aug 28, 2023
| * | ||
| * @param listener Listener to initialize. | ||
| */ | ||
| LD_EXPORT(void) LDFlagListener_Init(struct LDFlagListener* listener); |
There was a problem hiding this comment.
Signature has changed from (struct LDFlagListener listener)
kinyoklion
approved these changes
Aug 28, 2023
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Aug 28, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.0.5</summary> ## [3.0.5](launchdarkly-cpp-client-v3.0.4...launchdarkly-cpp-client-v3.0.5) (2023-08-28) ### Bug Fixes * initialization of LDFlagListener ([#218](#218)) ([6c263dd](6c263dd)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.1.6 to 0.1.7 * launchdarkly-cpp-common bumped from 0.3.3 to 0.3.4 </details> <details><summary>launchdarkly-cpp-common: 0.3.4</summary> ## [0.3.4](launchdarkly-cpp-common-v0.3.3...launchdarkly-cpp-common-v0.3.4) (2023-08-28) ### Bug Fixes * initialization of LDFlagListener ([#218](#218)) ([6c263dd](6c263dd)) </details> <details><summary>launchdarkly-cpp-internal: 0.1.7</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-common bumped from 0.3.3 to 0.3.4 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the definition and implementation of
LDFlagListenerintocommon, so it can be easily shared with the server.Additionally, it fixes a bug in the specification of the
LDFlagListener_Initmethod. It previously tookLDFlagListenerby value; now it takes a pointer.The impact would be if a customer forgot to initialize the struct, then the member(s) would be undefined.