Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing quotation marks in \fontname with harfbuzz #285

Open
Udi-Fogiel opened this issue Jul 2, 2024 · 3 comments
Open

missing quotation marks in \fontname with harfbuzz #285

Udi-Fogiel opened this issue Jul 2, 2024 · 3 comments
Assignees
Labels
bug Something isn't working fixed in dev already fixed

Comments

@Udi-Fogiel
Copy link

run with luahbtex

\input luaotfload.sty

\font\foo="name:TeX Gyre Termes:mode=harf"\relax
\fontname\foo

\font\foo="name:TeX Gyre Termes"\relax
\fontname\foo

\bye

This is causing problems in LaTeX as the kernel assume \fontname can be
fed up to \font back again, and since the font name has spaces and \fontname
does not have any protection (no braces, nor quotation marks) this
leads to errors. See https://tex.stackexchange.com/questions/721772/conflict-between-setmainfont-and-mainmatter.

@Udi-Fogiel
Copy link
Author

BTW, if the quotation marks or braces are just for escaping spaces, wouldn't removing them and the spaces will be easier?

@u-fischer
Copy link
Member

I guess that is a similar problem to latex3/fontspec#486

@zauguin
Copy link
Member

zauguin commented Jul 6, 2024

Fixed in dev with 80c94d6, but the underlying issue is that patch_font callbacks do not run for harf fonts. I'm wondering if that might have other effects too. It's probably not safe to chsnge though since these fonts do look very different and aren't very patchable.

@zauguin zauguin added bug Something isn't working fixed in dev already fixed labels Jul 6, 2024
@zauguin zauguin self-assigned this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev already fixed
Projects
None yet
Development

No branches or pull requests

3 participants