Moving discriminant parameters to component base #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving the discriminant to the base type we ensure that the component model always matches the implementation. When the discriminant is reflected in the implementation, it was up to the user to keep the model in sync with the code, which is far from ideal. This commit fixes that issue.
|
Abandoning. This does not quite work with the way Ada handles inherited discriminants, ie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the discriminant to the base type we ensure that the component model always matches the implementation. When the discriminant is reflected in the implementation, it was up to the user to keep the model in sync with the code, which is far from ideal. This commit fixes that issue.