Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Liger #2

Open
lapp0 opened this issue Aug 24, 2024 · 2 comments
Open

Integrate Liger #2

lapp0 opened this issue Aug 24, 2024 · 2 comments

Comments

@lapp0
Copy link
Owner

lapp0 commented Aug 24, 2024 •
edited
Loading

https://github.com/linkedin/Liger-Kernel

Should be easy with linkedin/Liger-Kernel#242 (comment)

Also we should patch kl_div loss with ligers kl_div if liger is available.
@ByronHsu
Copy link

thanks :-)

@lapp0
Copy link
Owner Author

lapp0 commented Oct 11, 2024

Integration complete, but awaiting linkedin/Liger-Kernel#272 because kl_div (and possibly other components) have broken grad computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lapp0 @ByronHsu