Add update support for embedding jobs on daemon #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var77
force-pushed
the
varik/embedding-update-triggers
branch
from
d9d2b17
to
eb81d59
Compare
Ngalstyan4
reviewed
Jan 31, 2024
| .unwrap(); | ||
| let client_data = db_client | ||
| .query_one( | ||
| &format!("SELECT COUNT(*) FROM {CLIENT_TABLE_NAME} WHERE title_embedding IS NULL AND title IS NULL"), |
There was a problem hiding this comment.
what are these actually testing?
are you testing somewhere that when you update title, corresponding embedding will be updated by the daemon to the new value?
var77
force-pushed
the
varik/embedding-update-triggers
branch
from
b423999
to
3095ad2
Compare
var77
force-pushed
the
varik/embedding-update-triggers
branch
from
82f7bbb
to
9e52a5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.