Bug fixes for norm calculation. #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oseikuffuor1
commented
Aug 23, 2023
oseikuffuor1
commented
- Fixed various bugs in norm calculation that implicitly assumed dense storage for sparse matrices.
- This fix should enable correct norm calculations on arbitrary sparse matrices.
* Fixed various bugs in norm calculation that implicitly assumed dense storage for sparse methods. * This fix should enable correct norms on arbitrary sparse matrices.
oseikuffuor1
requested review from
nicolasbock,
suemni,
tokshgithub and
jmohdyusof
as code owners
suemni
approved these changes
Aug 23, 2023
jeanlucf22
reviewed
Aug 24, 2023
jeanlucf22
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.