From ae6ed8b71c55a05c55ae60c4deb6071f1982f977 Mon Sep 17 00:00:00 2001
From: Fred Jonsson <fridrik@pyth.net>
Date: Tue, 20 Aug 2024 17:40:13 +0100
Subject: [PATCH] feat: support `name` parameter to `update_run` (#927)

This change makes it possible to update the name of a run after it has
been created. Previously, run names could not be modified once set.
---
 python/langsmith/client.py                    | 4 ++++
 python/langsmith/run_trees.py                 | 1 +
 python/tests/integration_tests/test_client.py | 2 ++
 3 files changed, 7 insertions(+)

diff --git a/python/langsmith/client.py b/python/langsmith/client.py
index b48a16be1..740bd1581 100644
--- a/python/langsmith/client.py
+++ b/python/langsmith/client.py
@@ -1435,6 +1435,7 @@ def update_run(
         self,
         run_id: ID_TYPE,
         *,
+        name: Optional[str] = None,
         end_time: Optional[datetime.datetime] = None,
         error: Optional[str] = None,
         inputs: Optional[Dict] = None,
@@ -1450,6 +1451,8 @@ def update_run(
         ----------
         run_id : str or UUID
             The ID of the run to update.
+        name : str or None, default=None
+            The name of the run.
         end_time : datetime or None
             The end time of the run.
         error : str or None, default=None
@@ -1469,6 +1472,7 @@ def update_run(
         """
         data: Dict[str, Any] = {
             "id": _as_uuid(run_id, "run_id"),
+            "name": name,
             "trace_id": kwargs.pop("trace_id", None),
             "parent_run_id": kwargs.pop("parent_run_id", None),
             "dotted_order": kwargs.pop("dotted_order", None),
diff --git a/python/langsmith/run_trees.py b/python/langsmith/run_trees.py
index 66887ada6..fd23426c9 100644
--- a/python/langsmith/run_trees.py
+++ b/python/langsmith/run_trees.py
@@ -268,6 +268,7 @@ def patch(self) -> None:
         if not self.end_time:
             self.end()
         self.client.update_run(
+            name=self.name,
             run_id=self.id,
             outputs=self.outputs.copy() if self.outputs else None,
             error=self.error,
diff --git a/python/tests/integration_tests/test_client.py b/python/tests/integration_tests/test_client.py
index d939111d4..bd7b583b5 100644
--- a/python/tests/integration_tests/test_client.py
+++ b/python/tests/integration_tests/test_client.py
@@ -336,9 +336,11 @@ def test_persist_update_run(langchain_client: Client) -> None:
         langchain_client.create_run(**run)
         run["outputs"] = {"output": ["Hi"]}
         run["extra"]["foo"] = "bar"
+        run["name"] = "test_run_updated"
         langchain_client.update_run(run["id"], **run)
         wait_for(lambda: langchain_client.read_run(run["id"]).end_time is not None)
         stored_run = langchain_client.read_run(run["id"])
+        assert stored_run.name == run["name"]
         assert stored_run.id == run["id"]
         assert stored_run.outputs == run["outputs"]
         assert stored_run.start_time == run["start_time"]