Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint validator produces incorrect stack traces #617

Open
benjamincburns opened this issue Oct 21, 2024 · 1 comment
Open

checkpoint validator produces incorrect stack traces #617

benjamincburns opened this issue Oct 21, 2024 · 1 comment

Comments

@benjamincburns
Copy link
Contributor

Per title, while using the checkpoint validator to validate my own custom checkpoint implementation just now, I noticed that the stack traces that it produces don't align correctly with the source. I think this is caused by swc-project/swc-node/#848.

Unfortunately this makes the errors produced by the test suite a bit confusing, as it'll cause the code snippet in the error output to be totally invalid. For example, in the screenshot below, the error in question is coming from the execution of a DynamoDB PutCommand at line 437, while the code snippet is pointing at the whitespace of line 291, which is in an entirely different method.

image

@benjamincburns
Copy link
Contributor Author

I believe that this was fixed by #624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant