Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqliteSaver.put stores config with undefined checkpoint_ns when config.configurable.checkpoint_ns is undefined. #592

Closed
benjamincburns opened this issue Oct 14, 2024 · 1 comment · Fixed by #634
Closed

SqliteSaver.put stores config with undefined checkpoint_ns when config.configurable.checkpoint_ns is undefined. #592

benjamincburns opened this issue Oct 14, 2024 · 1 comment · Fixed by #634

Comments

@benjamincburns
Copy link
Contributor

benjamincburns commented Oct 14, 2024 •
edited
Loading

Found while working on #541. Relevant code is here (value is unchecked).
This was referenced Oct 15, 2024
Merged
Merged
@benjamincburns
Copy link
Contributor Author

Per #582 (comment) - it would also be nice if whomever did this included a change that migrated the type of the metadata column to jsonb rather than blob so that the query for list didn't need to reproject this column to jsonb in its WHERE clause (causes a linear scan).

benjamincburns added a commit to benjamincburns/langgraphjs that referenced this issue Oct 25, 2024
@benjamincburns
fix(checkpoint-sqlite): don't return undefined namespace from put
d1bb0d1 
fixes langchain-ai#592
benjamincburns added a commit to benjamincburns/langgraphjs that referenced this issue Oct 25, 2024
@benjamincburns
fix(checkpoint-sqlite): don't return undefined namespace from put
193965c 
fixes langchain-ai#592
@benjamincburns benjamincburns mentioned this issue Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(checkpoint-sqlite): don't return undefined namespace from put benjamincburns/langgraphjs
1 participant
@benjamincburns