-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-common [Feature]: Grounding with Google Search and Vertex AI Search #5073
Comments
Do we have a standard way of defining non-FunctionCall tools? (@jacoblee93) |
Not at the moment - thinking so far has been to always support the model-specific format and make the |
My thinking has been that there would be a function call version of it (for most models to use), but also a function call that a specific model could check for and then use. So a Gemini model, for example, might check for a function |
Hi @afirstenberg and @jacoblee93, we are students from the University of Toronto and we are interested in contributing to this issue. We noticed that a similar issue: langchain-ai/langchain-google/issues/146 was recently completed, so we were wondering if this issue is still open for contribution. If so, we would like to implement a similar solution based on the existing one from langchain-google. Thanks! 😄 |
Hey @williamc99! I think this should work if you call Sorry for the delayed response |
No worries, my team and I will get started right away! |
@williamc99 - Please keep me in the loop on what you and your team are seeing or if you have questions. When I first looked at this, I had several thoughts around this:
I may have misunderstood something, or things may have changed since I last looked at it, so take a look and we can discuss. |
Thank you, these will be great to keep into consideration. We'll keep you updated and reach out if we have any questions. 😀 |
@williamc99 - Wanted to followup and see how it's going. Google just announced Grounding with Google Search as a tool that is available through both the Vertex AI API and AI Studio API. My cursory look says that the JSON is identical for both platforms, so this part should be straightforward. |
@afirstenberg - Thanks for following up, and sorry for the delay! I took a look at the link and I agree that it should just be a straightforward addition. A question I had was whether we should stick to the default threshold for dynamic retrieval (0.3) or if there was a specific value that we should use? Also, for full transparency, we just finished with midterm exams and it slowed our progress more than expected. We're currently learning the codebase but we expect to have a lot more time to work on the feature now. We appreciate your guidance and will keep you updated on our progress! |
I think it should be easy enough to make that a parameter to the tool and to default to not providing a value (and thus using the default that Google is using). All of that is the easy part! 😅 The more difficult part will be the changes that I outlined above. |
Hello @afirstenberg and @jacoblee93, I am from the same team as @williamc99. We deeply apologize for the delay, but we have good news! We’ve implemented grounding with Google Search and Vertex AI Search. You can find our code here: GitHub Repository. To use this feature, simply call Here are the implementation details:
We've also added test cases and documentation changes. We have initiated a pull request. Please review our code and let us know your feedback. |
Privileged issue
Issue Content
See https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/grounding
See langchain-ai/langchain-google#146
The text was updated successfully, but these errors were encountered: