Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor PHP version and missing php.ini error #87

Closed
rubenvarela opened this issue Mar 8, 2024 · 4 comments
Closed

Minor PHP version and missing php.ini error #87

rubenvarela opened this issue Mar 8, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@rubenvarela
Copy link
Collaborator

Test .lando.yml file.

name: 20240308-lando-lamp
recipe: acquia
config:
  ah_application_uuid: 123
  ah_site_group: 123
  webroot: .
  xdebug: 'develop,debug'

To reproduce, lando start,

Error:

Box Requirements Checker
========================

> Using PHP 7.4.33
> PHP is using the following php.ini file:
  WARNING: No configuration file (php.ini) used by PHP!

> Checking Box requirements:
  E................



 [ERROR] Your system is not ready to run the application.




Fix the following mandatory requirements:
=========================================

 * The application requires a version matching "^8.1".

This is probably coming from acli, https://github.com/acquia/cli/blob/a52dddc14cc615b32f4e8daf113918fd217eb3af/composer.json#L15

If we are defaulting to latest,

acli_version: latest
, we should probably update the minimum version from 7.4.

Personally, I think tracking the newest version at Acquia and allowing downgrading with user interaction would be a good option. This would allow developing and testing against the 'latest and greatest' and find issues before they arise on prod.

@rubenvarela rubenvarela added the bug Something isn't working label Mar 8, 2024
@reynoldsalec
Copy link
Member

@rubenvarela agreed; noticed this when I was working on some of the config as well.

Looks like Acquia currently uses 8.1 as the default, you want to take a stab at updating that @rubenvarela? I think you just need to update the default value in the builders/acquia.js and then make sure any of the tests in the examples directory that check PHP version and don't have it overriden in the .lando.yml are looking for 8.1, not 7.4. I don't mind doing it, so no worries if you're busy, just let me know!

@rubenvarela
Copy link
Collaborator Author

@reynoldsalec for sure. Happy to send the PR for this.

@rubenvarela
Copy link
Collaborator Author

@reynoldsalec when you get a sec. I have a PR for this for you to review.

@reynoldsalec reynoldsalec added the flag Flag an issue for discussion in relevant contrib meeting label Apr 3, 2024
@reynoldsalec reynoldsalec removed the flag Flag an issue for discussion in relevant contrib meeting label Apr 3, 2024
@rubenvarela
Copy link
Collaborator Author

Closed by #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants