Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue using MariaDB database #100

Closed
spfaffly opened this issue Apr 19, 2024 · 2 comments · Fixed by #101
Closed

Issue using MariaDB database #100

spfaffly opened this issue Apr 19, 2024 · 2 comments · Fixed by #101
Assignees
Labels
bug Something isn't working flag Flag an issue for discussion in relevant contrib meeting

Comments

@spfaffly
Copy link

I saw there was work done recently to add MariaDB. I tried adding database: mariadb in the config: portion in my .lando.yml file and it looked like it didn't take - it would still install MySQL.

The only way I could get MariaDB to install would be to specify it under the services:

database: 
      type: mariadb

And to my understanding this isn't the proper way - but I could be wrong. Any help would be appreciated. Thanks!

@spfaffly spfaffly added the bug Something isn't working label Apr 19, 2024
@reynoldsalec
Copy link
Member

@spfaffly Mariadb isn't a configuration option of Acquia, but you've made a good point. A lot of the recipes had an undocumented ability to change their database option to something other than a documented value, hence why we kept adding MariadB functionality to them.

The Acquia recipe is actually hardcoded to mysql:5.7: https://github.com/lando/acquia/blob/main/builders/acquia.js#L29 Since it doesn't even have that undocumented ability, we should completely remove MariaDB to prevent this type of confusion. Good catch!

@reynoldsalec reynoldsalec added the flag Flag an issue for discussion in relevant contrib meeting label Apr 19, 2024
@reynoldsalec
Copy link
Member

@rubenvarela or @uberhacker know you've been active on Acquia if you want to take a look at this...and apologies to @uberhacker, I didn't realize this was the case with Acquia until @spfaffly pointed it out.

@rubenvarela rubenvarela self-assigned this May 14, 2024
@rubenvarela rubenvarela linked a pull request May 14, 2024 that will close this issue
9 tasks
@reynoldsalec reynoldsalec moved this from Todo to In Progress in Lando Plugin Contribution Board May 14, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lando Plugin Contribution Board May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flag Flag an issue for discussion in relevant contrib meeting
Projects
Development

Successfully merging a pull request may close this issue.

3 participants