Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that aliases work for every ServiceManager feature #158

Closed
Slamdunk opened this issue Oct 14, 2022 · 3 comments
Closed

Check that aliases work for every ServiceManager feature #158

Slamdunk opened this issue Oct 14, 2022 · 3 comments

Comments

@Slamdunk
Copy link
Contributor

See laminas/laminas-form#193 (comment)

A test shold be added to ensure that Factories, Abstract Factories, Delegators, Initializers, Services and so on work well with alias and aliased references when an alias is in place

@boesing
Copy link
Member

boesing commented Jan 22, 2023

Related to my RFC in #168
Should we close here instead or should me make this one an RFC?

IMHO not a bug but a feature request tho.

@boesing boesing added Feature Request and removed Bug Something isn't working labels Jan 22, 2023
@Slamdunk
Copy link
Contributor Author

I'm not 100% sure they are the same topic: I'll let you decide though as it seems you have a much deeper knowledge and experience than me here

@boesing
Copy link
Member

boesing commented Jan 22, 2023

When I understand this issue correct, you want to ensure that delegator factories are called for aliases as well.
Depending on how upstream configures/replaces SM configuration, this might not always work but at least we could add aliases delegator factories to the chain.
Everything else, i.e. factories (which makes no sense in combination with aliases) and initializers do work (as they are triggered for all created services, no matter if aliased or not).

Especially the issue you mentioned initially was one of the reason I've created the RFC as v4 is not that far away anymore.

@boesing boesing closed this as completed Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants