From e722f1e450802fc04d1dae46d9f221ee2c3f1dae Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Sun, 5 Dec 2021 18:22:48 +0900 Subject: [PATCH 1/2] Drop `laminas/laminas-zendframework-bridge` and `zendframework/*` compatibility Increase performance by removing a compatibility layer while **not** introducing breaking changes. This follow the process described in details in: https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages Signed-off-by: Adrien Crivelli --- composer.json | 7 +++---- composer.lock | 22 ++++++++++++---------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/composer.json b/composer.json index e48316a..d6452f1 100644 --- a/composer.json +++ b/composer.json @@ -20,8 +20,7 @@ }, "require": { "php": "^7.3 || ~8.0.0", - "laminas/laminas-stdlib": "^2.7.7 || ^3.1", - "laminas/laminas-zendframework-bridge": "^1.0" + "laminas/laminas-stdlib": "^2.7.7 || ^3.1" }, "require-dev": { "laminas/laminas-coding-standard": "~1.0.0", @@ -58,7 +57,7 @@ "test": "phpunit --colors=always", "test-coverage": "phpunit --colors=always --coverage-clover clover.xml" }, - "replace": { - "zendframework/zend-file": "^2.8.3" + "conflict": { + "zendframework/zend-file": "*" } } diff --git a/composer.lock b/composer.lock index 091162a..1e5d79d 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "1118debc53d9a3b3bc4d333092fe5344", + "content-hash": "7a4f32a06a4b33a1773e24553da20355", "packages": [ { "name": "laminas/laminas-stdlib", @@ -66,24 +66,26 @@ }, { "name": "laminas/laminas-zendframework-bridge", - "version": "1.1.1", + "version": "1.4.0", "source": { "type": "git", "url": "https://github.com/laminas/laminas-zendframework-bridge.git", - "reference": "6ede70583e101030bcace4dcddd648f760ddf642" + "reference": "bf180a382393e7db5c1e8d0f2ec0c4af9c724baf" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/laminas/laminas-zendframework-bridge/zipball/6ede70583e101030bcace4dcddd648f760ddf642", - "reference": "6ede70583e101030bcace4dcddd648f760ddf642", + "url": "https://api.github.com/repos/laminas/laminas-zendframework-bridge/zipball/bf180a382393e7db5c1e8d0f2ec0c4af9c724baf", + "reference": "bf180a382393e7db5c1e8d0f2ec0c4af9c724baf", "shasum": "" }, "require": { - "php": "^5.6 || ^7.0 || ^8.0" + "php": "^7.3 || ~8.0.0 || ~8.1.0" }, "require-dev": { - "phpunit/phpunit": "^5.7 || ^6.5 || ^7.5 || ^8.1 || ^9.3", - "squizlabs/php_codesniffer": "^3.5" + "phpunit/phpunit": "^9.3", + "psalm/plugin-phpunit": "^0.15.1", + "squizlabs/php_codesniffer": "^3.5", + "vimeo/psalm": "^4.6" }, "type": "library", "extra": { @@ -122,7 +124,7 @@ "type": "community_bridge" } ], - "time": "2020-09-14T14:23:00+00:00" + "time": "2021-09-03T17:53:30+00:00" } ], "packages-dev": [ @@ -2998,5 +3000,5 @@ "php": "^7.3 || ~8.0.0" }, "platform-dev": [], - "plugin-api-version": "2.0.0" + "plugin-api-version": "2.1.0" } From e927d7b2feb597ba90eba0b83927566b27dfdeac Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Mon, 6 Dec 2021 15:40:41 +0900 Subject: [PATCH 2/2] Correct order of expectation Signed-off-by: Adrien Crivelli --- test/ClassFileLocatorTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/ClassFileLocatorTest.php b/test/ClassFileLocatorTest.php index 7acc54c..68d65f5 100644 --- a/test/ClassFileLocatorTest.php +++ b/test/ClassFileLocatorTest.php @@ -191,8 +191,8 @@ public function testIgnoresMethodsNamedAfterKeywords() }, []); $expected = [ - TestAsset\WithMethodsNamedAfterKeywords\WithReturnTypeDeclaration::class, TestAsset\WithMethodsNamedAfterKeywords\WithoutReturnTypeDeclaration::class, + TestAsset\WithMethodsNamedAfterKeywords\WithReturnTypeDeclaration::class, ]; $this->assertEquals($expected, $classNames, '', 0.0, 10, true);