Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove php:<8.0 support, effectively removing all binaries and extensions from the container #150

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Mar 2, 2023

Needs laminas/laminas-ci-matrix-action#196

Fixes #149

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA yes

@Ocramius Ocramius added BC Break Enhancement Feature Removal dependencies Pull requests that update a dependency file labels Mar 2, 2023
@Ocramius Ocramius added this to the 2.0.0 milestone Mar 2, 2023
@Ocramius Ocramius self-assigned this Mar 2, 2023
Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Targeting a v2 this does what it says in the title 👍 .

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcobucci lcobucci merged commit 020f90f into laminas:2.0.x Mar 2, 2023
@lcobucci lcobucci linked an issue Mar 2, 2023 that may be closed by this pull request
@boesing
Copy link
Member

boesing commented Apr 26, 2023

How do we handle jobs with PHP versions not supported by this action?

Since we did not yet merged both matrix container + CI action into same repository (started with it, but haven't finished due to lack of time/patience), projects consuming CI container v2 + Matrix container v1 will provide php versions outside of the supported range.

Can we probably move v2 of this and matrix container to https://github.com/laminas/laminas-continuous-integration?
So we can keep releases of matrix + container in-sync starting with v2.

Or is something highly depending on these changes here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break dependencies Pull requests that update a dependency file Enhancement Feature Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for EOL PHP versions in next major release
5 participants