Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Add max_amount and max_price_per_unit fields for V3 transactions #401

Open
pefontana opened this issue Jan 12, 2024 · 0 comments
Open

Add max_amount and max_price_per_unit fields for V3 transactions #401

pefontana opened this issue Jan 12, 2024 · 0 comments

Comments

@pefontana
Copy link
Collaborator

pefontana commented Jan 12, 2024

While updating to Juno v0.9.2 we get some errors in the V3 transactions with the required fields.
That is because V3 transactions had repalced the max_fee field for max_amount and max_price_per_unit
https://docs.starknet.io/documentation/architecture_and_concepts/Network_Architecture/fee-mechanism-pre-v0.13.0/#introduction

Check the required fields that had changed in the transactions and fix them.
Also, handle the UI to show the corresponding info regarding the transaction version

To replicate the error Uncomment this line
Invoke tx
https://github.com/lambdaclass/stark_compass_explorer/pull/400/files#diff-4accac252f39284c2dac2945600d334b697208ad0b2cb8f3dc920a491a6b1b98R247
Deplot Account tx
https://github.com/lambdaclass/stark_compass_explorer/pull/407/files#diff-4accac252f39284c2dac2945600d334b697208ad0b2cb8f3dc920a491a6b1b98R257

@pefontana pefontana changed the title Check the required fields in Invoke transactions Check the required fields in transactions Jan 16, 2024
@pefontana pefontana changed the title Check the required fields in transactions Add max_amount and max_price_per_unit fields for V3 transactions Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant