Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21 Missing Flags #22

Open
richard-livingston opened this issue Apr 29, 2014 · 9 comments
Open

21 Missing Flags #22

richard-livingston opened this issue Apr 29, 2014 · 9 comments

Comments

@richard-livingston
Copy link

After testing I found there were 21 missing flags...

  • AX:Åland Islands
  • BV:Bouvet Island
  • IO:British Indian Ocean Territory
  • CX:Christmas Island
  • CC:Cocos (Keeling) Islands
  • FK:Falkland Islands (Malvinas)
  • GF:French Guiana
  • TF:French Southern Territories
  • HM:Heard Island and Mcdonald Islands
  • YT:Mayotte
  • NU:Niue
  • NF:Norfolk Island
  • MP:Northern Mariana Islands
  • PN:Pitcairn
  • SH:Saint Helena
  • PM:Saint Pierre and Miquelon
  • GS:South Georgia and The South Sandwich Islands
  • SJ:Svalbard and Jan Mayen
  • TK:Tokelau
  • UM:United States Minor Outlying Islands
  • WF:Wallis and Futuna
@richard-livingston
Copy link
Author

Actually I just noticed 5 of these flags already exist, but the cloud.github url hasn't been updated

@scramatte
Copy link

We need spanish region flags : catalonia, valencia, euskadi (basque), galicia, ...
http://en.wikipedia.org/wiki/Flags_of_the_autonomous_communities_of_Spain

@lafeber
Copy link
Owner

lafeber commented Jun 8, 2015

The icon set at https://www.gosquared.com/resources/flag-icons/ solves most of these missing flags. @scramatte Specific region flags will not be included - sorry - this is for countries only. Perhaps it's a good idea to have a separate repo for these.

@kiwibrew
Copy link

kiwibrew commented Oct 8, 2015

Added a flag for Niue in #40

@quentindemetz
Copy link

I would also like to request a flag for Catalonia

@lafeber
Copy link
Owner

lafeber commented Mar 3, 2016

@quentindemetz Specific region flags will not be included - sorry - this is for countries only. I'll be the first to include the flag once Catalonia becomes independent!

@quentindemetz
Copy link

I'm not aware of all the use-cases of this library. Personally, I use it to provide a language picker for my customers and some of them speak Catalan. I agree we don't want to provide a flag for the thousands of languages out there but then again it doesn't seem (to me) like Catalan is a minority language. It kinda sucks having to include one more image file for just one language and being able to rely on your great sprite for everybody else...

Furthermore, I believe exceptions are already being made to this "rule" (see here for OPEC, _Commonwealth, _Olimpic_Movement, _Red_Cross, _NATO). So where's the harm in making yet another small exception ? It seems like it will only increase the sprite size by < 1%, which is a minor con.

Thanks for the great work so far and let me know if you change your position :)

@trfx
Copy link

trfx commented Dec 9, 2016

Can you add a flag for EU? Would be nice.

@johnnyshields
Copy link

johnnyshields commented Sep 14, 2017

@lafeber I urge you to support all countries in the ISO 3166-1 alpha-2 standard. I think this ISO standard is a very clear-cut way to determine what is a country and what is not.

Other libraries for example Google's "libphone" maps phone numbers to these ISO alpha-2 country codes and we get flag missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants