-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21 Missing Flags #22
Comments
Actually I just noticed 5 of these flags already exist, but the cloud.github url hasn't been updated |
We need spanish region flags : catalonia, valencia, euskadi (basque), galicia, ... |
The icon set at https://www.gosquared.com/resources/flag-icons/ solves most of these missing flags. @scramatte Specific region flags will not be included - sorry - this is for countries only. Perhaps it's a good idea to have a separate repo for these. |
Added a flag for Niue in #40 |
I would also like to request a flag for Catalonia |
@quentindemetz Specific region flags will not be included - sorry - this is for countries only. I'll be the first to include the flag once Catalonia becomes independent! |
I'm not aware of all the use-cases of this library. Personally, I use it to provide a language picker for my customers and some of them speak Catalan. I agree we don't want to provide a flag for the thousands of languages out there but then again it doesn't seem (to me) like Catalan is a minority language. It kinda sucks having to include one more image file for just one language and being able to rely on your great sprite for everybody else... Furthermore, I believe exceptions are already being made to this "rule" (see here for OPEC, _Commonwealth, _Olimpic_Movement, _Red_Cross, _NATO). So where's the harm in making yet another small exception ? It seems like it will only increase the sprite size by < 1%, which is a minor con. Thanks for the great work so far and let me know if you change your position :) |
Can you add a flag for EU? Would be nice. |
@lafeber I urge you to support all countries in the ISO 3166-1 alpha-2 standard. I think this ISO standard is a very clear-cut way to determine what is a country and what is not. Other libraries for example Google's "libphone" maps phone numbers to these ISO alpha-2 country codes and we get flag missing. |
After testing I found there were 21 missing flags...
AX:Åland IslandsBV:Bouvet IslandYT:MayotteNU:NiueSH:Saint HelenaSJ:Svalbard and Jan MayenThe text was updated successfully, but these errors were encountered: