Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - LogInterceptor #19

Open
viniciusbaltoe opened this issue Sep 1, 2021 · 0 comments
Open

Feature request - LogInterceptor #19

viniciusbaltoe opened this issue Sep 1, 2021 · 0 comments
Assignees

Comments

@viniciusbaltoe
Copy link

I think it would be interesting if in LogInterceptor there was a print referring to the request made, so that it is possible, from the logs, to determine which actions were requested from the delegate.

To demonstrate what I mean, I'll use is-wire-py's Basic Request/Reply example.

So far, the log acquired by LogInterceptor is in the following format:

[I][MainThread][2021-09-01 20:14:19,280][LogInterceptor] took=0.2005620002746582s, code=OK

With the addition of the information mentioned above, I imagine the format could look like this:

[I][MainThread][2021-09-01 20:14:19,280][LogInterceptor] took=0.2005620002746582s, code=OK, request=MyService.Increment

Or maybe:

[I][MainThread][2021-09-01 20:14:19,280][LogInterceptor] took=0.2005620002746582s, code=OK, request=Increment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants