Add c.Response().Committed check in example customHTTPErrorHandler #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doc updated addresses labstack/echo#1948 in the best way I can guess it should be handled. @markhildreth-gravity summarized that issue best by offering three solutions:
The first seems inappropriate since most handlers won't use
c.Error
(Its doc says this: "Avoid using this method in handlers as no middleware will be able to effectively handle errors after that.") The third puts more burden on developers since middleware functions are more common than error handlers.