Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response: clarify Content-Disposition, close file in Stream example #351

Merged
merged 1 commit into from
Oct 3, 2024
Merged

response: clarify Content-Disposition, close file in Stream example #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions website/docs/guide/response.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ func(c echo.Context) error {
## Send Attachment

`Context#Attachment(file, name string)` is similar to `File()` except that it is
used to send file as attachment with provided name.
used to send file as `Content-Disposition: attachment` with provided name.

*Example*

Expand All @@ -257,7 +257,7 @@ func(c echo.Context) error {
## Send Inline

`Context#Inline(file, name string)` is similar to `File()` except that it is
used to send file as inline with provided name.
used to send file as `Content-Disposition: inline` with provided name.

*Example*

Expand Down Expand Up @@ -296,6 +296,7 @@ func(c echo.Context) error {
if err != nil {
return err
}
defer f.Close()
return c.Stream(http.StatusOK, "image/png", f)
}
```
Expand Down
Loading