response: clarify Content-Disposition, close file in Stream example #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't clear to me what were the differences between `Context#File`, `Context#Attachment` and `Context#Inline` - reading the source made it clearer: the former 2 are referring to sending `Content-Disposition` with `attachment` and `inline`, which makes sense. Adding missing `defer f.Close()` in the `Context#Stream` example. I also checked, it takes an `io.Reader` not an `io.ReadCloser` so it couldn't delegate the close to `Context#Stream`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just discovered Echo while reading Stripe's payments Go demo, I'm going through the docs and so far I'm a big fan of the minimalistic approach! I hate bloat and love minimalist things (e.g. also just found PicoCSS for web design). Good stuff, can't wait to start coding with it, and thank you for sharing it.
Anyhow, this PR proposes 2 minor changes:
When reading the Response doc, it wasn't clear to me what were the differences between
Context#File,Context#AttachmentandContext#Inline. Reading the source made it clearer: the former 2 are referring to sendingContent-Dispositionwithattachmentandinline, which makes total sense. Therefore, I propose addingContent-Dispositionto make this unambiguous.Adding missing
defer f.Close()in theContext#Streamexample. I also checked, it takes anio.Readernot anio.ReadCloserso it couldn't delegate the close toContext#Stream, which could have worked otherwise!