Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

active flag to resource shipping_method not working correct #547

Closed
lyczkop opened this issue Dec 4, 2024 · 1 comment · Fixed by #548
Closed

active flag to resource shipping_method not working correct #547

lyczkop opened this issue Dec 4, 2024 · 1 comment · Fixed by #548
Labels
bug Something isn't working

Comments

@lyczkop
Copy link

lyczkop commented Dec 4, 2024 •
edited
Loading

Version information

  • terraform: 1.9.0
  • terraform provider: 1.18.0
  • commit: 4641456 ;)

Describe the bug

After update provider 1.17 -> 1.18 shipping_methods has been disabled by terraform

To Reproduce

Update provider to 1.18 and run apply

Expected behavior

shipping_methods will be still active as they was
@lyczkop lyczkop added bug Something isn't working triage Needs triage labels Dec 4, 2024
@demeyerthom demeyerthom removed the triage Needs triage label Dec 4, 2024
@demeyerthom
Copy link
Member

Ah an oversight I think. Default for that field should obviously be true. I will create a fix!

@demeyerthom demeyerthom linked a pull request Dec 4, 2024 that will close this issue
fix: made shipping_method active field default to true #548
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: made shipping_method active field default to true labd/terraform-provider-commercetools
2 participants
@demeyerthom @lyczkop