Add "Example aliases" to README #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu08
reviewed
Dec 13, 2024
README.md
Outdated
Comment on lines
114
to
125
| ### Setting Up | ||
| 1. Add the above lines to your shell's configuration file: | ||
| * For bash: `~/.bashrc` | ||
| * For zsh: `~/.zshrc` | ||
| * For fish: `~/.config/fish/config.fish` (use alias syntax as shown above) | ||
| 1. Reload your shell configuration: | ||
| bash/zsh: `source ~/.bashrc` or `source ~/.zshrc` | ||
| fish: `source ~/.config/fish/config.fish` | ||
| ### Example Usage | ||
| * `fm`: Launch fzf-make to select and run a target. | ||
| * `fr`: Repeat the last executed command. | ||
| * `fh`: Open fzf-make with the history pane focused. |
There was a problem hiding this comment.
I think it's enough that showing example settings only. 👍
So please delete L114-L125.
Suggested change
| ### Setting Up | |
| 1. Add the above lines to your shell's configuration file: | |
| * For bash: `~/.bashrc` | |
| * For zsh: `~/.zshrc` | |
| * For fish: `~/.config/fish/config.fish` (use alias syntax as shown above) | |
| 1. Reload your shell configuration: | |
| bash/zsh: `source ~/.bashrc` or `source ~/.zshrc` | |
| fish: `source ~/.config/fish/config.fish` | |
| ### Example Usage | |
| * `fm`: Launch fzf-make to select and run a target. | |
| * `fr`: Repeat the last executed command. | |
| * `fh`: Open fzf-make with the history pane focused. |
README.md
Outdated
Comment on lines
12
to
17
| <p align="center"> | ||
| [English] | ||
| [<a href="doc/README-de.md">Deutsch</a>] | ||
| [<a href="doc/README-fr.md">Français</a>] | ||
| </p> | ||
|
|
There was a problem hiding this comment.
I'm sorry for giving you a misunderstanding.
Please revert this deletion. 🙏
In description of #301, I wanted to show that READMEs other than English just need not to modified.
I'm going to delete them by another PR.
|
@kyu08 |
kyu08
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #301
Example aliasesin the README.