-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OptiGUI support #69
Conversation
There's a lot to add and to discuss
OptiGUI interaction happens elsewhere
The code is ready for review and discussion. |
Thanks for this! I'll look over everything soon. I would prefer this to be an optional dependency, not required. I can do that part though. |
A note about the code: it relies on packets sent in order, and |
Now OptiGUI is an optional dependency. You may decide to include it in "suggests" or "recommends". And yes, I tested it without OptiGUI and it didn't crash with |
OptiGUI 2.0.0-beta.4 will introduce breaking change. I'll rewrite the code once OptiGUI 2.0.0 full release arrives, and open a new PR. Which will take some time. |
After the breaking change in OptiGUI 2.1.0-beta.1, the code has shrunk in size. I have updated the code. Notes:
To be discussed:
|
Can you port this to 1.20/.1? I'll do another look over then |
Not in the next two weeks, I'm having some time off coding and I may refactor OptiGUI again after that. I'll open another PR on the 1.20 branch when ready |
What works
To be implemented
UseItemCallback
is processed server-side. Probably needs a client-side hook as wellTo be changed (maybe)
To be discussed
Services.getService()
throws if service is not found. The services used by the code are registered by OptiGUICloses #59
Closes opekope2/OptiGUI#19