3.8 compatability

[l300lvl]

this should seriously be worked on to include support for versions above 3.4, as honestly things should be much more mature and I think theres some better documentation going on as of late.

I'm gonna test this for the fun of it to see what errors are spit out, but I'm pretty sure shell status box itself has some extensive changes after 3.4

[l300lvl]

So according to this https://mail.gnome.org/archives/commits-list/2012-August/msg00774.html the statusIconDispatcher has been removed because of ibus

I'm not going to be of much help updating this on my own, but hopefully this will help you, at any rate Im still playing around with it.

[l300lvl]

the errors:

JS ERROR: !!!   Exception was: Error: No JS module 'statusIconDispatcher' found in search path
JS ERROR: !!!     message = '"No JS module 'statusIconDispatcher' found in search path"'
JS ERROR: !!!     fileName = '"/home/Bryan/.local/share/gnome-shell/extensions/[email protected]/extension.js"'
JS ERROR: !!!     lineNumber = '10'
JS ERROR: !!!     stack = '"@/home/Bryan/.local/share/gnome-shell/extensions/[email protected]/extension.js:10

"'
JS LOG: Extension "[email protected]" had error: Error: No JS module 'statusIconDispatcher' found in search path

i then thought Id try doing something like const StatusIconDispatcherOrig = new StatusIconDispatcher.StatusIconDispatcher();

but alas:

JS ERROR: !!!   Exception was: TypeError: StatusIconDispatcher.StatusIconDispatcher is not a constructor
JS ERROR: !!!     message = '"StatusIconDispatcher.StatusIconDispatcher is not a constructor"'
JS ERROR: !!!     fileName = '"/home/Bryan/.local/share/gnome-shell/extensions/[email protected]/extension.js"'
JS ERROR: !!!     lineNumber = '10'
JS ERROR: !!!     stack = '"@/home/Bryan/.local/share/gnome-shell/extensions/[email protected]/extension.js:10

"'

I'm stumped, and hopefully its obvious that I'm not that experienced with any kind of real coding.

[kylehuff]

Yeah, I don't have a version of gnome-shell greater than 3.2. I will have to setup a test system and find a way to work around the statusIconDispatcher issue.

Do any of the other features work in your version of gnome-shell? (i.e. DnD indicators, show/hide indicators, enable/disable extensions)

[l300lvl]

No it cant be enabled at all due to the original error. I have found some useful info from the above link as well as from the very informational mathematicalcoffee here http://mathematicalcoffee.blogspot.com/2012/11/upgrading-your-gnome-shell-extensions.html

with this info i did a lot of changes and I still cant get a panel icon, or get any to move, but I do get the notice to restart the shell, yet it has no effect when it does restart. I may have removed something I shouldnt have though. Here is what I have done, with these changes it enables/disabled and I get the restart shell notice and nothing more, but also no more errors from console:

http://paste.opensuse.org/view/raw/41244590

I realize the status area around line 430 probably needs fixed still, but hopefully some of this helps a bit.

[l300lvl]

note I forgot to mention I removed all of the status icon dispatcher stuff, so that could be a problem but I was hoping to at least get it running without any errors and then hopefully at least have the ability to rearrange the panels indicators, as I would be happy with that ability for now regardless of if tray implementation ever works.

[kylehuff]

My last commit brings the extension closer to v3.8 compatibility; however I still don't have access to gnome-shell v3.8 -- still building on my test machine.

The extension should now run flawlessly in v3.2.2.1 and v3.4.1 (and I would assume everything in-between)

[l300lvl]

this is great news! I wonder if removing the statusicondispatcher stuff might get this going under 3.8 now. im excited to see this happen.

[l300lvl]

this may be useful in some ways: https://extensions.gnome.org/extension/495/topicons/

it does work on 3.8 so it is possible to at least put all icons on top. im going to play with my previous idea though and see what happens.

[kylehuff]

The latest commit works in 3.6.2 (everything except the trayIcon support).

It may or may not work in 3.8, I still don't have a working 3.8 installation, so I can't test.

[l300lvl]

Sorry I didnt get very far, as I said I am not very experienced, but I think you are...

As it stands, it works in 3.8. I have noticed a couple bugs, but all I changed was the metadata on the last commit. One thing I noticed is the drag here to hide modal does not always go away:

http://i.imgur.com/4212oLm.png

Also a couple extensions don't work properly, for instance my Show Desktop Button extensions indicator seems to have moved on its own, and it can not be moved due the actor it creates, hopefully this can be fixed, but I may need to do work on that extension. I can always use the preferences panel of my extension to move it back though, but I don't know how that will play with indecision yet:
https://github.com/l300lvl/Show-Desktop-Button

The move tray icons to top option doesn't work, even after restarting the shell, but that's understandable, you don't even have 3.8 and this is working pretty good. But the restart shell modal reappears even after a restart. It went away after I toggled that option off and restarted the shell again though.

Overall this is awesome, and I'm going to do some more testing now :D

[kylehuff]

Yes, the "drag here to hide" dialog will not go away if there was an exception/error. It should always go away, even if the drag-n-drop methods fail. That is on my list of things to fix.

As for the tray icons, there is no support for that in this extension on gnome-panel 3.6 and above. I am still working on that part.

I'll see what I can find regarding the show-desktop-button extension, but that might be another issue (not related to gnome-shell v3.8).

Would you be able to provide me a screenshot of the the "Extensions" and "Indicators" items expanded? I'm curious to know how many are not parsed correctly. Along that vein, when you expand the "indicators" item and hover over a named Indicator, does it highlight the corresponding indicator in your panel as intended? I didn't touch that method since the initial version for gnome-shell 3.2, so I'm curious if it still works.

[l300lvl]

Ok.

Understood about the tray icons, they need better overall implementation anyhow.

As for show-desktop-button, that is an issue on my end I suppose, the Caffeine indicator has problems as well where it will enable/disable the actual indicator, recording the button click event I guess. I need to update show-desktop-button to use a different button method anyways, I've just been lazy.

I'll post some screnshots here in a moment, and if you don't care is it ok to share a screencast of this working on irc, it is some pretty amazing eye candy...

Yes, it highlights correctly, including for show desktop button, but you may notice a problem there. Screenshots to come:

[kylehuff]

Share away. I wrote it for the good of all man kind.

If you want to speak in real-time while debugging/testing, I can be found on the freenode irc server in #curetheitch

[l300lvl]

Maybe ill include a note to not move the show desktop button for now since i do have a prefs tool option for that which works fine in 3.6-3.8, it correctly moves the indicator if i dont use the extension to try to move it, which really doesn't work as it doesn't try to grab it that I see, but it then removes it.

Also, when you choose to hide indicators, how are they to be recovered?

http://i.imgur.com/XCXc5Pn.png
http://i.imgur.com/KqGpYJl.png
http://i.imgur.com/V1jy0Yi.png

this last one is interesting:
http://i.imgur.com/VElJeX0.png

[kylehuff]

More than likely, the "interesting" item in your list is the show desktop button, and that means it failed to find the delegate object. I will look at the reason(s) why.

Also, when you hide an indicator, they are simply hidden. To restore them, click on the indecision icon, click on "Indicators" and toggle the desired indicator. It will be shown again (barring any errors).